Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add NOMINMAX definitions when compiling with MSVC #283

Merged
merged 9 commits into from
Feb 21, 2019
Merged

Add NOMINMAX definitions when compiling with MSVC #283

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
3fd0f24
Add NOMINMAX definitions when compiling with MSVC
meastp Feb 19, 2019
e7c031c
Merge branch 'master' into meastp_msvc_add_nominmax
g-easy Feb 20, 2019
a6d2bfb
Add comment describing NOMINMAX
meastp Feb 20, 2019
3624221
Add comment describing NOMINMAX definition on MSVC
meastp Feb 20, 2019
6462eb2
Merge branch 'master' into meastp_msvc_add_nominmax
g-easy Feb 21, 2019
8a763cc
update comment
g-easy Feb 21, 2019
4b226a5
update other comment
g-easy Feb 21, 2019
c6d864f
format 1/2
g-easy Feb 21, 2019
8a1b764
format 2/2
g-easy Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions opencensus/common/internal/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ opencensus_lib(common_random

opencensus_lib(common_stats_object DEPS absl::time)

target_compile_definitions(opencensus_common_stats_object INTERFACE $<$<CXX_COMPILER_ID:MSVC>:NOMINMAX>)
g-easy marked this conversation as resolved.
Show resolved Hide resolved

opencensus_lib(common_string_vector_hash)

opencensus_test(common_random_test random_test.cc common_random)
Expand Down
2 changes: 2 additions & 0 deletions opencensus/stats/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,8 @@ opencensus_lib(stats_core
absl::optional
absl::span)

target_compile_definitions(opencensus_stats_core PUBLIC $<$<CXX_COMPILER_ID:MSVC>:NOMINMAX>)

opencensus_lib(stats_recording
SRCS
internal/recording.cc
Expand Down