This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
CMake: Add Google Benchmark (with FetchContent) #296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meastp
force-pushed
the
meastp_cmake_google_benchmark
branch
2 times, most recently
from
2343b3d
to
36f29c2
Compare
meastp
changed the title
|
Please fix the cmake-on-linux break on Travis: https://travis-ci.org/census-instrumentation/opencensus-cpp/jobs/506125611 Regarding format, please try out #299 |
|
@g-easy Unfortunately, the docker container did not work fully. All the sed commands fail with |
meastp
force-pushed
the
meastp_cmake_google_benchmark
branch
from
36f29c2
to
d375a97
Compare
|
I managed to run format.sh (with some modifications, see #310). |
g-easy
reviewed
Apr 3, 2019
g-easy
reviewed
Apr 3, 2019
|
This is looking good! |
meastp
force-pushed
the
meastp_cmake_google_benchmark
branch
from
629858a
to
4d246cf
Compare
meastp
force-pushed
the
meastp_cmake_google_benchmark
branch
from
4d246cf
to
b57d2fd
Compare
|
ok, fixed comments :) |
g-easy
approved these changes
Apr 5, 2019
|
Awesome! Thank you! Wanna go tick the benchmarks box in #244 ? :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds google benchmark to dependencies, and opencensus' benchmarks to the cmake build