This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Added parameters to tools/format.sh (Windows) #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-easy
reviewed
Apr 4, 2019
|
It passes on Travis now. @meastp are you happy with my edits / the state of this PR in general? |
|
Thank you for the fixes, @g-easy - LGTM :) |
g-easy
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds parameters for skipping the sed operations and/or the operations that require installed software (clang-format, cmake-format ...).
The usage scenario is that @g-easy 's Docker-container is not useable in Windows Docker because the sed operations fail. However, the workaround is easy:
I have tested this, and it works very well :)