This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Check if Stackdriver MetricDescriptor is compatible with the view #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakyll
commented
Nov 28, 2017
| a = &stats.DistributionAggregation{} | ||
| } | ||
|
|
||
| if reflect.TypeOf(agg) != reflect.TypeOf(a) { |
There was a problem hiding this comment.
We should also check whether agg is a pointer or not, or disallow concrete types to be passed as aggregators.
| if reflect.TypeOf(agg) != reflect.TypeOf(a) { | ||
| return false | ||
| } | ||
| if reflect.TypeOf(window) != reflect.TypeOf(w) { |
songy23
approved these changes
Nov 28, 2017
rakyll
force-pushed
the
sda
branch
2 times, most recently
from
54313eb
to
40abbb2
Compare
|
Added the labels, and addressed the concrete type vs pointers. |
songy23
approved these changes
Nov 28, 2017
| @@ -189,26 +191,36 @@ func (e *Exporter) makeReq(vds []*stats.ViewData) *monitoringpb.CreateTimeSeries | |||
| } | |||
| } | |||
|
|
|||
| // createMeasure creates a MetricDescriptor for the given view data in Stackdriver Monitoring. | |||
| // If there is already a metric descriptor created with the same name | |||
| // and the metric descriptor has a different aggregation/window, it returns an error. | |||
There was a problem hiding this comment.
nit: aggregation/window -> aggregation/window/tag keys
| _, ok := e.createdViews[viewName] | ||
| if ok { | ||
| if md, ok := e.createdViews[viewName]; ok { | ||
| // Check agg and window. |
jcd2
reviewed
Nov 29, 2017
| }) | ||
| if err := equalAggWindowTagKeys(md, agg, window, tagKeys); err != nil { |
There was a problem hiding this comment.
This call to equalAggWindowTagKeys should be moved inside the "if err == nil" block below.
bogdandrutu
pushed a commit
to bogdandrutu/opencensus-go
that referenced
this pull request
Feb 15, 2019
…nterceptor and exporter are enabled (census-instrumentation#162)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146.