This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Add Jaeger support to README and fix links #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeke-em
approved these changes
Jan 30, 2018
| @@ -255,7 +256,7 @@ An example logger exporter is below: | |||
|
|
|||
| type exporter struct{} | |||
|
|
|||
| func (e *exporter) Export(vd *stats.ViewData) { | |||
| func (e *exporter) ExportView(vd *stats.ViewData) { | |||
There was a problem hiding this comment.
Did we forget to perhaps do this in the internal/readme/source.md file too? I don't know how the embedmd stuff works :)
There was a problem hiding this comment.
I assumed someone changed README rather than internal/readme/source.md.
bogdandrutu
pushed a commit
to bogdandrutu/opencensus-go
that referenced
this pull request
Feb 15, 2019
Adding a timeout to tests to help cache any test that maybe deadlocking with certain frequency.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.