Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Add Jaeger support to README and fix links #383

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Add Jaeger support to README and fix links #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ Currently, OpenCensus supports:

* [Prometheus][exporter-prom] for stats
* [OpenZipkin][exporter-zipkin] for traces
* Stackdriver [Monitoring][exporter-sdstats] and [Trace][exporter-sdtrace]
* Stackdriver [Monitoring][exporter-stackdriver] and [Trace][exporter-stackdriver]
* [Jaeger][exporter-jaeger] for traces

## Tags

Expand Down Expand Up @@ -255,7 +256,7 @@ An example logger exporter is below:

type exporter struct{}

func (e *exporter) Export(vd *stats.ViewData) {
func (e *exporter) ExportView(vd *stats.ViewData) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we forget to perhaps do this in the internal/readme/source.md file too? I don't know how the embedmd stuff works :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed someone changed README rather than internal/readme/source.md.

log.Println(vd)
}

Expand All @@ -267,8 +268,8 @@ func (e *exporter) Export(vd *stats.ViewData) {

[embedmd]:# (trace.go startend)
```go
ctx = trace.StartSpan(ctx, "your choice of name")
defer trace.EndSpan(ctx)
ctx, span := trace.StartSpan(ctx, "your choice of name")
defer span.End()
```

More tracing examples are coming soon...
Expand Down Expand Up @@ -314,6 +315,6 @@ A screenshot of the CPU profile from the program above:
[newtags-replace-ex]: https://godoc.org/go.opencensus.io/tag#example-NewMap--Replace

[exporter-prom]: https://godoc.org/go.opencensus.io/exporter/prometheus
[exporter-sdstats]: https://godoc.org/go.opencensus.io/exporter/stackdriver
[exporter-stackdriver]: https://godoc.org/go.opencensus.io/exporter/stackdriver
[exporter-zipkin]: https://godoc.org/go.opencensus.io/exporter/zipkin
[exporter-sdtrace]: https://godoc.org/go.opencensus.io/exporter/trace/stackdriver
[exporter-jaeger]: https://godoc.org/go.opencensus.io/exporter/jaeger
11 changes: 6 additions & 5 deletions internal/readme/source.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ Currently, OpenCensus supports:

* [Prometheus][exporter-prom] for stats
* [OpenZipkin][exporter-zipkin] for traces
* Stackdriver [Monitoring][exporter-sdstats] and [Trace][exporter-sdtrace]
* Stackdriver [Monitoring][exporter-stackdriver] and [Trace][exporter-stackdriver]
* [Jaeger][exporter-jaeger] for traces

## Tags

Expand Down Expand Up @@ -178,7 +179,7 @@ A screenshot of the CPU profile from the program above:
[newtags-ex]: https://godoc.org/go.opencensus.io/tag#example-NewMap
[newtags-replace-ex]: https://godoc.org/go.opencensus.io/tag#example-NewMap--Replace

[exporter-prom]: https://godoc.org/go.opencensus.io/exporter/stats/prometheus
[exporter-sdstats]: https://godoc.org/go.opencensus.io/exporter/stats/stackdriver
[exporter-zipkin]: https://godoc.org/go.opencensus.io/exporter/trace/zipkin
[exporter-sdtrace]: https://godoc.org/go.opencensus.io/exporter/trace/stackdriver
[exporter-prom]: https://godoc.org/go.opencensus.io/exporter/prometheus
[exporter-stackdriver]: https://godoc.org/go.opencensus.io/exporter/stackdriver
[exporter-zipkin]: https://godoc.org/go.opencensus.io/exporter/zipkin
[exporter-jaeger]: https://godoc.org/go.opencensus.io/exporter/jaeger