This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Don't record measurements with no subscription #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can actually easily use the ref count. |
rakyll
force-pushed
the
a
branch
3 times, most recently
from
c0bdcc4
to
a37ffec
Compare
rakyll
changed the title
semistrict
approved these changes
Mar 18, 2018
stats/record.go
Outdated
| // Record records one or multiple measurements with the same tags at once. | ||
| // If there are any tags in the context, measurements will be tagged with them. | ||
| func Record(ctx context.Context, ms ...Measurement) { | ||
| if len(ms) == 0 { | ||
| var filtered []Measurement |
There was a problem hiding this comment.
I don't think it is worth it to construct a filtered slice here. I think we can make this even cheaper by:
- Instead of having a subscribed call per measure, have
Mconstruct aMeasurewith nilmand define this to mean that the Measurement is ignored - Just do a pass over the
msand check if all are ignored and drop if that's the case, otherwise pass the originalms - In the view code, filter the Measurements by
Measure() != nilwhen processing view updates.
This would avoid allocations in append and also virtual calls to subscribed.
| @@ -57,6 +58,7 @@ func (cmd *subscribeToViewReq) handleCommand(w *worker) { | |||
| errstr = append(errstr, fmt.Sprintf("%s: %v", view.Name, err)) | |||
| continue | |||
| } | |||
| internal.SubscriptionReporter(view.Measure.Name()) | |||
There was a problem hiding this comment.
may as well just pass Measure and call the .subscribe directly
There was a problem hiding this comment.
I can't, it creates a circular dependency.
| @@ -22,10 +22,24 @@ import ( | |||
| "go.opencensus.io/tag" | |||
| ) | |||
|
|
|||
| func init() { | |||
| internal.SubscriptionReporter = func(measure string) { | |||
There was a problem hiding this comment.
may as well accept Measure and set internal.SubscriptionReporter = measure.subscribed
There was a problem hiding this comment.
I can't, it creates a circular dependency.
rakyll
force-pushed
the
a
branch
4 times, most recently
from
2ef573f
to
8c3b385
Compare
Suggested by Ramon, immediately dropping the measurements from the measures with no subscription rather than doing it at a later time significantly improves the performance on the critical path. Before: BenchmarkRecord0-8 500000000 3.09 ns/op BenchmarkRecord1-8 5000000 366 ns/op BenchmarkRecord8-8 3000000 412 ns/op BenchmarkRecord8_Parallel-8 2000000 804 ns/op BenchmarkRecord8_8Tags-8 3000000 415 ns/op After: BenchmarkRecord0-8 1000000000 2.58 ns/op BenchmarkRecord1-8 30000000 36.9 ns/op BenchmarkRecord8-8 20000000 89.4 ns/op BenchmarkRecord8_Parallel-8 30000000 44.8 ns/op BenchmarkRecord8_8Tags-8 20000000 90.1 ns/op
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by Ramon, immediately dropping the measurements from
the measures with no subscription rather than doing it at a later time
significantly improves the performance on the critical path.
Before:
BenchmarkRecord0-8 500000000 3.09 ns/op
BenchmarkRecord1-8 5000000 366 ns/op
BenchmarkRecord8-8 3000000 412 ns/op
BenchmarkRecord8_Parallel-8 2000000 804 ns/op
BenchmarkRecord8_8Tags-8 3000000 415 ns/op
After:
BenchmarkRecord0-8 500000000 3.75 ns/op
BenchmarkRecord1-8 30000000 39.7 ns/op
BenchmarkRecord8-8 20000000 101 ns/op
BenchmarkRecord8_Parallel-8 30000000 40.1 ns/op
BenchmarkRecord8_8Tags-8 20000000 102 ns/op