This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Introduce trace.Config #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @bogdandrutu @savaki |
bogdandrutu
reviewed
Mar 28, 2018
trace/config.go
Outdated
| @@ -0,0 +1,36 @@ | |||
| // Copyright 2017, OpenCensus Authors | |||
| if !hasParent { | ||
| span.spanContext.TraceID = newTraceIDLocked() | ||
| } | ||
| span.spanContext.SpanID = newSpanIDLocked() | ||
| sampler := defaultSampler | ||
| sampler := config.DefaultSampler |
There was a problem hiding this comment.
Is this thread safe? Shouldn't you use something like this: https://golang.org/pkg/sync/atomic/#Value?
There was a problem hiding this comment.
This whole block is guarded by a mutex right now.
If you are asking about the reference, in Go, things are pass by value. User cannot mutate the config.DefaultSampler.
There was a problem hiding this comment.
If you prefer atomic values for all the global state, I added a TODO for that.
semistrict
approved these changes
Mar 28, 2018
trace.Config allows to set global configuration for tracing and deprecating the global default sampler setter. Fixes census-instrumentation#652.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace.Config allows to set global configuration for tracing
and deprecating the global default sampler setter.
Fixes #652.