This repository has been archived by the owner on Jul 31, 2023. It is now read-only.
Introduce trace.Config #652
Assignees
Labels
Comments
rakyll
added a commit
to rakyll/opencensus-go
that referenced
this issue
Mar 28, 2018
trace.Config allows to set global configuration for tracing and deprecating the global default sampler setter. Fixes census-instrumentation#652.
Merged
rakyll
added a commit
to rakyll/opencensus-go
that referenced
this issue
Mar 28, 2018
trace.Config allows to set global configuration for tracing and deprecating the global default sampler setter. Fixes census-instrumentation#652.
rakyll
added a commit
to rakyll/opencensus-go
that referenced
this issue
Mar 28, 2018
trace.Config allows to set global configuration for tracing and deprecating the global default sampler setter. Fixes census-instrumentation#652.
rakyll
added a commit
to rakyll/opencensus-go
that referenced
this issue
Mar 28, 2018
trace.Config allows to set global configuration for tracing and deprecating the global default sampler setter. Fixes census-instrumentation#652.
rakyll
added a commit
that referenced
this issue
Mar 28, 2018
trace.Config allows to set global configuration for tracing and deprecating the global default sampler setter. Fixes #652.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The trace package doesn't implement the TraceConfig spec which is the canonical API to set global settings: https://github.com/census-instrumentation/opencensus-specs/blob/master/trace/TraceConfig.md.
We should deprecate the global sampler setter and allow users to set the global config via the new API.
A global configuration setter will be also useful for extending capabilities in the future. And we can allow users to provide custom implementations of generation.
/cc @savaki
The text was updated successfully, but these errors were encountered: