Use options.host instead of options.hostname (#416) (#417)

census-instrumentation · Mar 13, 2019 · 66ebc78 · 66ebc78
1 parent 096eb70
commit 66ebc78
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/packages/opencensus-instrumentation-http/src/http.ts b/packages/opencensus-instrumentation-http/src/http.ts
@@ -377,9 +377,8 @@ export class HttpPlugin extends BasePlugin {
           const tags = new TagMap();
           tags.set(stats.HTTP_CLIENT_METHOD, {value: method});
 
-          if (options.hostname) {
-            span.addAttribute(HttpPlugin.ATTRIBUTE_HTTP_HOST, options.hostname);
-          }
+          const host = options.hostname || options.host || 'localhost';
+          span.addAttribute(HttpPlugin.ATTRIBUTE_HTTP_HOST, host);
           span.addAttribute(HttpPlugin.ATTRIBUTE_HTTP_METHOD, method);
           if (options.path) {
             span.addAttribute(HttpPlugin.ATTRIBUTE_HTTP_PATH, options.path);