This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Use options.host instead of options.hostname (#416) #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinmel
requested review from
draffensperger,
justindsmith and
mayurkale22
as code owners
mayurkale22
reviewed
Mar 12, 2019
| @@ -377,8 +377,8 @@ export class HttpPlugin extends BasePlugin { | |||
| const tags = new TagMap(); | |||
| tags.set(stats.HTTP_CLIENT_METHOD, {value: method}); | |||
|
|
|||
| if (options.hostname) { | |||
There was a problem hiding this comment.
I think hostname is preferred over host. I would suggest to add below line.
const host = options.hostname || options.host || 'localhost'; WDYT?
There was a problem hiding this comment.
const host = options.hostname || options.host || 'localhost';
span.addAttribute(HttpPlugin.ATTRIBUTE_HTTP_HOST, host);
This change will also fix failing build.
jinmel
commented
Mar 13, 2019
| @@ -377,8 +377,8 @@ export class HttpPlugin extends BasePlugin { | |||
| const tags = new TagMap(); | |||
| tags.set(stats.HTTP_CLIENT_METHOD, {value: method}); | |||
|
|
|||
| if (options.hostname) { | |||
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=========================================
+ Coverage 94.79% 94.8% +<.01%
=========================================
Files 136 136
Lines 8999 8997 -2
Branches 665 663 -2
=========================================
- Hits 8531 8530 -1
+ Misses 468 467 -1
Continue to review full report at Codecov.
|
mayurkale22
approved these changes
Mar 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #416