Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Wrong translation to stackdriver span #474

Closed
jinmel opened this issue Apr 5, 2019 · 4 comments
Closed

Wrong translation to stackdriver span #474

jinmel opened this issue Apr 5, 2019 · 4 comments
Labels
bug Fixed

Comments

@jinmel
Copy link
Contributor

jinmel commented Apr 5, 2019 •
edited
Loading

Please answer these questions before submitting a bug report.

What version of OpenCensus are you using?

0.0.10

What version of Node are you using?

10.15

What did you do?

ran examples in //examples/http/ with StackdriverTraceExporter instead of ZipkinTraceExporter

What did you expect to see?

A span in stackdriver console

What did you see instead?

nothing

Additional context

it works for jaeger tracer exporter, but not with stackdriver exporter. i wonder where the bug is.
@jinmel
Copy link
Contributor Author

jinmel commented Apr 5, 2019

I only see span for
GET /latest/dynamic/instance-identity/document

@jinmel
Copy link
Contributor Author

jinmel commented Apr 5, 2019

atchWriteSpans error: Invalid JSON payload received. Unknown name "uncompressed_size" at 'spans[0].time_events.time_event[0].message_event': Cannot find field.
Invalid JSON payload received. Unknown name "compressed_size" at 'spans[0].time_events.time_event[0].message_event': Cannot find field.

@jinmel jinmel changed the title http instrumentation not working for stackdriver Wrong translation to stackdriver span Apr 5, 2019
jinmel added a commit to jinmel/opencensus-node that referenced this issue Apr 5, 2019
@jinmel
Fix error in opencensus to stackdriver translation (census-instrument…
8d48b77 
…ation#474)

  - compressedSize -> compressedSizeBytes
  - uncompressedSize -> uncompressedSizeBytes
@jinmel
Copy link
Contributor Author

jinmel commented Apr 5, 2019

https://github.com/googleapis/googleapis/blob/327ff9c09f4b2bcc9633f035a58ad348e45fb2a0/google/devtools/cloudtrace/v2/trace.proto#L97

mayurkale22 pushed a commit that referenced this issue Apr 5, 2019
@jinmel @mayurkale22
Fix error in opencensus to stackdriver translation (#474) (#475)
aa889b2 
- compressedSize -> compressedSizeBytes
  - uncompressedSize -> uncompressedSizeBytes
@mayurkale22
Copy link
Member

Closed in #475

@mayurkale22 mayurkale22 mentioned this issue Apr 8, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jinmel @mayurkale22