This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Fix error in opencensus to stackdriver translation (#474) #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation#474) - compressedSize -> compressedSizeBytes - uncompressedSize -> uncompressedSizeBytes
jinmel
requested review from
draffensperger,
justindsmith and
mayurkale22
as code owners
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
=========================================
+ Coverage 94.79% 94.8% +0.01%
=========================================
Files 150 150
Lines 9875 9876 +1
Branches 742 742
=========================================
+ Hits 9361 9363 +2
+ Misses 514 513 -1
Continue to review full report at Codecov.
|
mayurkale22
approved these changes
Apr 5, 2019
I'll help you to cut the release soon (might be on monday). |
This was referenced Apr 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've told my boss that last bug fix and publishing 0.0.10 milestone will be the cure for failing opencensus instrumentation last week and it seems like I'd need to wait more
going for a beer cheers!