Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

add default value when attributes are not specified #351

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

mayurkale22
Copy link
Member

This will fix the issue when we export data to Stackdriver backend https://github.com/census-instrumentation/opencensus-node/blob/master/packages/opencensus-exporter-stackdriver/src/stackdriver-cloudtrace-utils.ts#L120, otherwise the program will crash when optional attributes is missing.

I have open an issue #348 to enable strictNullChecks on this repo.

@codecov-io
Copy link

Codecov Report

Merging #351 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
+ Coverage   95.23%   95.27%   +0.03%     
==========================================
  Files         122      122              
  Lines        8277     8288      +11     
  Branches      608      610       +2     
==========================================
+ Hits         7883     7896      +13     
+ Misses        394      392       -2
Impacted Files Coverage Δ
src/adapters.ts 96% <0%> (-1%) ⬇️
test/test-root-span.ts 100% <0%> (ø) ⬆️
test/test-ocagent.ts 91.74% <0%> (ø) ⬆️
src/trace/model/span-base.ts 98.79% <0%> (+0.02%) ⬆️
src/stackdriver-monitoring.ts 84.21% <0%> (+3.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21b64a0...7e08fef. Read the comment docs.

@mayurkale22 mayurkale22 merged commit 4530fc6 into census-instrumentation:master Feb 19, 2019
@mayurkale22 mayurkale22 deleted the minorfix branch February 19, 2019 23:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants