This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 97
http-instrumentation: fix propagation errors when using Expect header #481 #482
Merged
mayurkale22
merged 3 commits into
census-instrumentation:master
from
vmarchaud:http-progagation-expect
Apr 11, 2019
Merged
http-instrumentation: fix propagation errors when using Expect header #481 #482
mayurkale22
merged 3 commits into
census-instrumentation:master
from
vmarchaud:http-progagation-expect
Apr 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmarchaud
requested review from
draffensperger,
justindsmith and
mayurkale22
as code owners
April 9, 2019 13:32
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
==========================================
- Coverage 94.83% 94.69% -0.15%
==========================================
Files 150 150
Lines 10153 9745 -408
Branches 752 737 -15
==========================================
- Hits 9629 9228 -401
+ Misses 524 517 -7
Continue to review full report at Codecov.
|
draffensperger
approved these changes
Apr 9, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor nits
@draffensperger I've rewritten the explanation and removed the link to the google trace agent's PR |
Looks good, thanks! |
mayurkale22
reviewed
Apr 9, 2019
Done @mayurkale22 |
mayurkale22
approved these changes
Apr 11, 2019
Thanks for the contribution @vmarchaud |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.