Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-instrumentation: fix propagation errors when using Expect header #481 #482

Merged

Conversation

Projects
None yet
5 participants
@vmarchaud
Copy link
Contributor

commented Apr 9, 2019

No description provided.

@codecov-io

This comment has been minimized.

Copy link

commented Apr 9, 2019

Codecov Report

Merging #482 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   94.83%   94.69%   -0.15%     
==========================================
  Files         150      150              
  Lines       10153     9745     -408     
  Branches      752      737      -15     
==========================================
- Hits         9629     9228     -401     
+ Misses        524      517       -7
Impacted Files Coverage Δ
src/trace/propagation/noop-propagation.ts 37.5% <0%> (-12.5%) ⬇️
src/internal/util.ts 90% <0%> (-10%) ⬇️
src/common/validations.ts 88.23% <0%> (-7.22%) ⬇️
src/tags/validation.ts 92.85% <0%> (-7.15%) ⬇️
src/trace/model/no-record/no-record-span.ts 54.54% <0%> (-1.02%) ⬇️
src/tags/propagation/text-format.ts 94.11% <0%> (-0.89%) ⬇️
src/tags/propagation/variant-encoding.ts 95% <0%> (-0.84%) ⬇️
src/trace/model/tracer.ts 85.71% <0%> (-0.26%) ⬇️
src/index.ts 100% <0%> (ø) ⬆️
src/http-stats.ts 100% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cb7e9...d238f30. Read the comment docs.

@draffensperger
Copy link
Contributor

left a comment

LGTM with minor nits

Show resolved Hide resolved packages/opencensus-instrumentation-http/src/http.ts Outdated
Show resolved Hide resolved packages/opencensus-instrumentation-http/src/http.ts Outdated
@vmarchaud

This comment has been minimized.

Copy link
Contributor Author

commented Apr 9, 2019

@draffensperger I've rewritten the explanation and removed the link to the google trace agent's PR

@draffensperger

This comment has been minimized.

Copy link
Contributor

commented Apr 9, 2019

Looks good, thanks!

@vmarchaud vmarchaud force-pushed the vmarchaud:http-progagation-expect branch from 4d7878b to 6456fe6 Apr 9, 2019

@vmarchaud vmarchaud force-pushed the vmarchaud:http-progagation-expect branch from eede501 to d238f30 Apr 11, 2019

@vmarchaud

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

@mayurkale22

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Thanks for the contribution @vmarchaud

@mayurkale22 mayurkale22 merged commit 9235b50 into census-instrumentation:master Apr 11, 2019

29 checks passed

ci/circleci: node10 Your tests passed on CircleCI!
Details
ci/circleci: node11 Your tests passed on CircleCI!
Details
ci/circleci: node6 Your tests passed on CircleCI!
Details
ci/circleci: node8 Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
security/snyk - examples/grpc/package.json (mayurkale22) No new issues
Details
security/snyk - package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-core/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-example-automatic-tracing/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-exporter-instana/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-exporter-jaeger/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-exporter-ocagent/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-exporter-prometheus/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-exporter-stackdriver/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-exporter-zipkin/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-exporter-zpages/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-instrumentation-all/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-instrumentation-grpc/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-instrumentation-http/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-instrumentation-http2/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-instrumentation-https/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-instrumentation-mongodb/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-nodejs/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-propagation-b3/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-propagation-binaryformat/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-propagation-jaeger/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-propagation-stackdriver/package.json (mayurkale22) No manifest changes detected
security/snyk - packages/opencensus-propagation-tracecontext/package.json (mayurkale22) No new issues
Details
security/snyk - packages/opencensus-resource-util/package.json (mayurkale22) No new issues
Details

@vmarchaud vmarchaud deleted the vmarchaud:http-progagation-expect branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.