Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

http-instrumentation: fix propagation errors when using Expect header #481 #482

Merged
merged 3 commits into from
Apr 11, 2019
Merged

http-instrumentation: fix propagation errors when using Expect header #481 #482

merged 3 commits into from
Apr 11, 2019

Conversation

vmarchaud
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 9, 2019

Codecov Report

Merging #482 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #482      +/-   ##
==========================================
- Coverage   94.83%   94.69%   -0.15%     
==========================================
  Files         150      150              
  Lines       10153     9745     -408     
  Branches      752      737      -15     
==========================================
- Hits         9629     9228     -401     
+ Misses        524      517       -7
Impacted Files Coverage Δ
src/trace/propagation/noop-propagation.ts 37.5% <0%> (-12.5%) ⬇️
src/internal/util.ts 90% <0%> (-10%) ⬇️
src/common/validations.ts 88.23% <0%> (-7.22%) ⬇️
src/tags/validation.ts 92.85% <0%> (-7.15%) ⬇️
src/trace/model/no-record/no-record-span.ts 54.54% <0%> (-1.02%) ⬇️
src/tags/propagation/text-format.ts 94.11% <0%> (-0.89%) ⬇️
src/tags/propagation/variant-encoding.ts 95% <0%> (-0.84%) ⬇️
src/trace/model/tracer.ts 85.71% <0%> (-0.26%) ⬇️
src/index.ts 100% <0%> (ø) ⬆️
src/http-stats.ts 100% <0%> (ø) ⬆️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0cb7e9...d238f30. Read the comment docs.

Copy link
Contributor

@draffensperger draffensperger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor nits

packages/opencensus-instrumentation-http/src/http.ts Outdated Show resolved Hide resolved
packages/opencensus-instrumentation-http/src/http.ts Outdated Show resolved Hide resolved
@vmarchaud
Copy link
Contributor Author

vmarchaud commented Apr 9, 2019

@draffensperger I've rewritten the explanation and removed the link to the google trace agent's PR

@draffensperger
Copy link
Contributor

Looks good, thanks!

@vmarchaud
Copy link
Contributor Author

Done @mayurkale22

@mayurkale22
Copy link
Member

Thanks for the contribution @vmarchaud

@mayurkale22 mayurkale22 merged commit 9235b50 into census-instrumentation:master Apr 11, 2019
@vmarchaud vmarchaud deleted the http-progagation-expect branch April 11, 2019 12:11
@mayurkale22 mayurkale22 added this to the Release 0.0.12 milestone May 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants