Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

http-instrumentation: propagation error when using Expect header #481

Closed
vmarchaud opened this issue Apr 9, 2019 · 1 comment
Closed

http-instrumentation: propagation error when using Expect header #481

vmarchaud opened this issue Apr 9, 2019 · 1 comment
Labels
bug P0
Milestone
Release 0.0.12

Comments

@vmarchaud
Copy link
Contributor

google-trace-nodejs had the same issue before: googleapis/cloud-trace-nodejs#766

I will make a PR later today to fix that
@mayurkale22 mayurkale22 added P0 and removed triage-me labels Apr 9, 2019
@mayurkale22 mayurkale22 added this to the Release 0.0.12 milestone Apr 9, 2019
@vmarchaud vmarchaud changed the title http-instrumentation: using propagation error when using Expect header http-instrumentation: propagation error when using Expect header Apr 11, 2019
mayurkale22 pushed a commit that referenced this issue Apr 11, 2019
@vmarchaud @mayurkale22
http-instrumentation: fix propagation errors when using Expect header #…
9235b50 
…481 (#482)

* http-instrumentation: fix propagation errors when using Expect header #481

* chore: more details for the Expect header logic

* chore: address PR comments
@mayurkale22
Copy link
Member

Addressed in #482

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug P0
Projects
None yet
Milestone
Release 0.0.12
Development

No branches or pull requests
2 participants
@vmarchaud @mayurkale22