Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http-instrumentation: propagation error when using Expect header #481

Closed
vmarchaud opened this Issue Apr 9, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@vmarchaud
Copy link
Contributor

commented Apr 9, 2019

google-trace-nodejs had the same issue before: googleapis/cloud-trace-nodejs#766

I will make a PR later today to fix that

vmarchaud added a commit to vmarchaud/opencensus-node that referenced this issue Apr 9, 2019

@mayurkale22 mayurkale22 added P0 and removed triage-me labels Apr 9, 2019

@mayurkale22 mayurkale22 added this to the Release 0.0.12 milestone Apr 9, 2019

@vmarchaud vmarchaud changed the title http-instrumentation: using propagation error when using Expect header http-instrumentation: propagation error when using Expect header Apr 11, 2019

mayurkale22 added a commit that referenced this issue Apr 11, 2019

http-instrumentation: fix propagation errors when using Expect header #…
…481 (#482)

* http-instrumentation: fix propagation errors when using Expect header #481

* chore: more details for the Expect header logic

* chore: address PR comments
@mayurkale22

This comment has been minimized.

Copy link
Collaborator

commented Apr 11, 2019

Addressed in #482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.