This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
feat: add stats implementation #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduardoemery
force-pushed
the
stats
branch
9 times, most recently
from
e135cdb
to
eda4b07
Compare
kjin
reviewed
Aug 14, 2018
| @@ -92,7 +92,7 @@ export class ConsoleStatsExporter implements types.StatsEventListener { | |||
| * @param view recorded view from measurement | |||
| * @param measurement recorded measurement | |||
| */ | |||
| onRecord(view: View, measurement: Measurement) { | |||
| console.log(`Measurement recorded: ${view.measure.name}`); | |||
| onRecord(views: View[], measurement: Measurement) { | |||
There was a problem hiding this comment.
Update JSDocs here and elsewhere.
There was a problem hiding this comment.
Updated, thanks for noticing.
| this.registerView(view); | ||
| return view; | ||
| } catch (err) { | ||
| throw (err); |
There was a problem hiding this comment.
Do we need this try-catch block?
There was a problem hiding this comment.
Hmm not really. This was used in another approach I was trying and it ended up staying. Thanks for noticing, removed.
| } | ||
|
|
||
| /** | ||
| * Registers an exporter to send stats data to a service. | ||
| * @param exporter An stats exporter | ||
| */ | ||
| registerExporter(exporter: StatsEventListener) { | ||
| throw new Error('Not Implemented'); | ||
| this.statsEventListeners.push(exporter); |
There was a problem hiding this comment.
Should we immediately notify it of all currently registered views?
There was a problem hiding this comment.
Definitely! I hadn't considered this case but it is really important! Thanks for the suggestion.
kjin
approved these changes
Aug 16, 2018
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
* feat: add stats implementation * refactor(fix): changes to address review comments
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
* feat: add stats implementation * refactor(fix): changes to address review comments
kjin
pushed a commit
to kjin/opencensus-node
that referenced
this pull request
Aug 24, 2018
* feat: add stats implementation * refactor(fix): changes to address review comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.