Allow for Flask init_app Pattern
#160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liyanhui1228
requested changes
Apr 20, 2018
docs/trace/usage.rst
Outdated
| @@ -209,6 +209,40 @@ requests will be automatically traced. | |||
| # `GoogleCloudFormatPropagator` as propagator. | |||
| middleware = FlaskMiddleware(app) | |||
|
|
|||
| The middleware also supports the factory pattern. | |||
| .. code:: python | |||
There was a problem hiding this comment.
Add a blank line before the code block? This part is not parsing by github correctly.
docs/trace/usage.rst
Outdated
| from opencensus.trace.ext.flask.flask_middleware import FlaskMiddleware | ||
| middleware = FlaskMiddleware() | ||
| app = flask.Flask(__name__) | ||
| middleware.init_app(app |
There was a problem hiding this comment.
Add the right parenthesis.
liyanhui1228
approved these changes
Apr 20, 2018
sonmezonur
pushed a commit
to sonmezonur/opencensus-python
that referenced
this pull request
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See http://flask.pocoo.org/docs/0.12/extensiondev/#initializing-extensions for common usage of this pattern. Also allows for configuration from the flask application.