Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata about temp nature of the table #1457

Merged

Conversation

Anish9901
Copy link
Member

@Anish9901 Anish9901 commented Jul 10, 2022

Fixes #1419

Technical details

Why do we need this metadata in the Table response object and our Table model at all?

  • One of the first step from the end-user perspective is to select the table they want the CSV file imported to, we would like to store this info somewhere so that even if the session abruptly ends we know where to pickup. To achieve this we are using the table_to_import_to field in this PR.
  • We also want to optionally drop the temp table, from where we've imported the data. To know that a table is a temp we are storing that info in our Django table model.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the master branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Anish9901 Anish9901 marked this pull request as ready for review July 11, 2022 18:17
@Anish9901 Anish9901 requested review from a team and removed request for a team July 11, 2022 18:17
@codecov-commenter

This comment was marked as off-topic.

@Anish9901 Anish9901 marked this pull request as draft July 13, 2022 17:11
@Anish9901 Anish9901 marked this pull request as ready for review July 25, 2022 12:30
@Anish9901 Anish9901 added the pr-status: review A PR awaiting review label Jul 25, 2022
Copy link
Contributor

@mathemancer mathemancer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I think this looks good, and we've disabled the E2E tests for now. So, I'll set this to merge once the CI pipeline runs.

@mathemancer mathemancer merged commit 8e40309 into mathesar-foundation:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
5 participants