-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata about temp nature of the table #1457
Merged
mathemancer
merged 15 commits into
mathesar-foundation:master
from
Anish9901:metadata_for_temp_table
Jul 27, 2022
Merged
Add metadata about temp nature of the table #1457
mathemancer
merged 15 commits into
mathesar-foundation:master
from
Anish9901:metadata_for_temp_table
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble_to_import_to field in TableSerailizer
This comment was marked as off-topic.
This comment was marked as off-topic.
silentninja
reviewed
Jul 12, 2022
…me in the Table model
mathemancer
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I think this looks good, and we've disabled the E2E tests for now. So, I'll set this to merge once the CI pipeline runs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1419
Technical details
Why do we need this metadata in the Table response object and our
Table
model at all?table_to_import_to
field in this PR.Checklist
Update index.md
).master
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin