Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make columns re-orderable #2831

Merged
merged 23 commits into from Jun 26, 2023

Conversation

AlekLefebvre
Copy link
Contributor

Fixes #1584, #2717, #2718, #2722

Fixes the critical regressions caused by #2213 and reverts #2731

Technical details
I had to convert the columnOrder to string[] inside mathesar_ui/src/systems/table-view/header/Header.svelte to fix #2722 and because of issues working with a "string[] | number[]" type.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@seancolsen seancolsen self-assigned this Apr 20, 2023
@seancolsen seancolsen added the pr-status: review A PR awaiting review label Apr 20, 2023
@seancolsen seancolsen changed the title Fix regressions 1584 Make columns re-orderable May 1, 2023
Copy link
Contributor

@seancolsen seancolsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent a few hours with this today and couldn't spot any remaining issues. I fixed a merge conflict and pushed 6b6066a with some minor code cleanup.

@seancolsen
Copy link
Contributor

@pavish Would you be interested in giving this a second look before we merge it?

@seancolsen seancolsen assigned pavish and unassigned seancolsen May 1, 2023
@rajatvijay rajatvijay added this to the Backlog milestone May 3, 2023
@pavish
Copy link
Member

pavish commented May 18, 2023

@AlekLefebvre I've kept the review/merge on hold since we are close to a release. This is on my tasklist and I will get this PR merged once we freeze our release branch for 0.1.2. This should be in a couple weeks.

Copy link
Member

@pavish pavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlekLefebvre This looks great!

Sorry for taking so long to get this merged in, we had a release pending and I wanted to wait until we had it out, and I was on vacation for a while after that.

Thank you for your effort!

@pavish pavish added this pull request to the merge queue Jun 26, 2023
Merged via the queue into mathesar-foundation:develop with commit c6dc923 Jun 26, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
4 participants