New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make columns re-orderable #2831
Make columns re-orderable #2831
Conversation
c240b0f
to
6b6066a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent a few hours with this today and couldn't spot any remaining issues. I fixed a merge conflict and pushed 6b6066a with some minor code cleanup.
@pavish Would you be interested in giving this a second look before we merge it? |
@AlekLefebvre I've kept the review/merge on hold since we are close to a release. This is on my tasklist and I will get this PR merged once we freeze our release branch for 0.1.2. This should be in a couple weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlekLefebvre This looks great!
Sorry for taking so long to get this merged in, we had a release pending and I wanted to wait until we had it out, and I was on vacation for a while after that.
Thank you for your effort!
c6dc923
Fixes #1584, #2717, #2718, #2722
Fixes the critical regressions caused by #2213 and reverts #2731
Technical details
I had to convert the columnOrder to string[] inside mathesar_ui/src/systems/table-view/header/Header.svelte to fix #2722 and because of issues working with a "string[] | number[]" type.
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin