Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default value input stealing focus #2957

Merged
merged 2 commits into from Jun 26, 2023
Merged

Conversation

seancolsen
Copy link
Contributor

Fixes #2857
Supplants #2951

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Contributor

@rajatvijay rajatvijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rajatvijay rajatvijay added this pull request to the merge queue Jun 26, 2023
Merged via the queue into develop with commit 4b8ccff Jun 26, 2023
13 checks passed
@rajatvijay rajatvijay deleted the 2857_default_value_focus branch June 26, 2023 09:26
@pavish
Copy link
Member

pavish commented Jun 26, 2023

@seancolsen @rajatvijay

I had a quick look here and there's a regression with this PR.

In the table, when a cell is activated, it should show the input and the input should auto focus. The focusOnMount prop here was used for that purpose. The bug was that instead of placing this prop in MoneyCell, it was placed within MoneyCellInput. This PR removes it from the MoneyCellInput and it would affect focusing within the table.

@seancolsen Would you be interested in raising a followup PR for this?

@seancolsen
Copy link
Contributor Author

Thanks for catching that, @pavish. I thought I tested that, but I guess I didn't do it correctly. I've opened #2974 for this and I'll work on a fix for it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: review A PR awaiting review
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Default value input steals focus when using keyboard to move active cell
3 participants