Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gherkin command migration script #2678

Merged
merged 15 commits into from
Jan 2, 2024
Merged

Add gherkin command migration script #2678

merged 15 commits into from
Jan 2, 2024

Conversation

mdebauchez
Copy link
Contributor

@mdebauchez mdebauchez commented Nov 21, 2023 •
edited
Loading

REF : MON-21761

@mdebauchez mdebauchez self-assigned this Dec 13, 2023
@mdebauchez mdebauchez marked this pull request as ready for review December 13, 2023 15:47
@mdebauchez mdebauchez requested a review from a team as a code owner December 13, 2023 15:47
mushroomempires
mushroomempires reviewed Dec 14, 2023
View reviewed changes
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
centreon/tests/e2e/features/Migration-scripts/01-command.feature Outdated Show resolved Hide resolved
@mdebauchez @mushroomempires
Apply suggestions from POU code review
212a5ff 
Co-authored-by: May <110405507+paul-oureib@users.noreply.github.com>
@mdebauchez mdebauchez marked this pull request as draft December 15, 2023 08:33
@mdebauchez mdebauchez marked this pull request as ready for review December 15, 2023 12:45
@mdebauchez mdebauchez requested review from a team and removed request for a team December 19, 2023 09:04
tuntoja
tuntoja reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@tuntoja tuntoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scenario: Validating presence of migrated command on the target platform
Scenario: Successful execution of the migration script

shouldn t these two be a single scenario ?

@github-actions GitHub Actions
Copy link

Code coverage report for centreon component 🚀

Coverage after merging MON-24871-Command-migration-script into develop will be
89.00%
Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines

@mdebauchez mdebauchez merged commit b191327 into develop Jan 2, 2024
265 checks passed
@mdebauchez mdebauchez deleted the MON-24871-Command-migration-script branch January 2, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuntoja tuntoja tuntoja approved these changes

@mushroomempires mushroomempires mushroomempires approved these changes

@bdauria bdauria Awaiting requested review from bdauria bdauria is a code owner automatically assigned from centreon/owners-gherkin

@pkippes pkippes Awaiting requested review from pkippes pkippes is a code owner automatically assigned from centreon/owners-gherkin

Assignees

@mdebauchez mdebauchez

Labels
area/test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mdebauchez @tuntoja @mushroomempires