Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Javascript client parser can't delimit one message from another if we send formatted JSON with new lines as we are not compacting JSON since recent update (i.e. using easyjson).
This pull request fixes this removing new lines in JSON if any. Also some helpers introduced to further reduce allocations in both Protobuf and JSON cases – we now reusing byte slices where it's safe to do, so we avoid extra byte slice copy and thus saving one allocation.
Before
After, without new line
After, with new line
So Protobuf is now faster regardless new lines - since it does not matter as we are using length-prefixed format. JSON encode is faster for already compact input and slightly slower (and +1 alloc) with input which contains new line.