Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1521 update api and identity types #1545

Merged
merged 112 commits into from
Nov 28, 2022
Merged

Conversation

cdamian
Copy link
Collaborator

@cdamian cdamian commented Aug 11, 2022

No description provided.

@cdamian cdamian force-pushed the 1521-update-api-and-identity-types branch from d8aada8 to b452eee Compare August 11, 2022 15:53
@cdamian cdamian force-pushed the 1521-update-api-and-identity-types branch 2 times, most recently from bd34581 to f41786a Compare August 15, 2022 09:05
@cdamian cdamian force-pushed the 1521-update-api-and-identity-types branch 7 times, most recently from 6a4d03f to d38e407 Compare November 21, 2022 12:56
Copy link
Contributor

@mikiquantum mikiquantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some minor comments

build/scripts/run_centrifuge_chain.sh Show resolved Hide resolved
identity/v2/service.go Outdated Show resolved Hide resolved
migration/files/00Initial_test.go Outdated Show resolved Hide resolved
p2p/client.go Outdated Show resolved Hide resolved
@cdamian cdamian force-pushed the 1521-update-api-and-identity-types branch from 6625b9a to 2e5eb9f Compare November 23, 2022 20:28
@cdamian cdamian force-pushed the 1521-update-api-and-identity-types branch from 46d6e0e to 69ef240 Compare November 24, 2022 07:39
@cdamian cdamian marked this pull request as ready for review November 25, 2022 16:38
@cdamian cdamian force-pushed the 1521-update-api-and-identity-types branch from e05e30a to c027cdd Compare November 25, 2022 16:44
@mikiquantum mikiquantum merged commit 70cfd09 into v1.4.0 Nov 28, 2022
@mikiquantum mikiquantum deleted the 1521-update-api-and-identity-types branch November 28, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants