Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Length Padded Fields #77 #79

Merged
merged 7 commits into from
May 10, 2019
Merged

Fixed Length Padded Fields #77 #79

merged 7 commits into from
May 10, 2019

Conversation

zyfrank
Copy link
Contributor

@zyfrank zyfrank commented May 9, 2019 •
edited by lucasvo
Loading

fixes #77

@codecov
Copy link

codecov bot commented May 9, 2019 •
edited
Loading

Codecov Report

Merging #79 into master will increase coverage by 0.67%.
The diff coverage is 91.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
+ Coverage   88.16%   88.84%   +0.67%     
==========================================
  Files           3        3              
  Lines         676      717      +41     
==========================================
+ Hits          596      637      +41     
- Misses         41       43       +2     
+ Partials       39       37       -2
Impacted Files Coverage Δ
proofs/tree.go 88.69% <100%> (+0.03%) ⬆️
proofs/flatten.go 83.51% <91.11%> (+2.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21e74a3...0458a5b. Read the comment docs.

lucasvo
lucasvo reviewed May 9, 2019
View reviewed changes
Copy link
Member

@lucasvo lucasvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments. I will review the test coverage later.

README.md Outdated Show resolved Hide resolved
examples/documents/example.proto Outdated Show resolved Hide resolved
@lucasvo lucasvo merged commit 9d502ff into centrifuge:master May 10, 2019
@gitcoinbot gitcoinbot mentioned this pull request May 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasvo lucasvo lucasvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixed Length Padded Fields
2 participants
@zyfrank @lucasvo