LPAIR+others: fix of single-dissociation symmetrisation #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forthommel
changed the title
|
Hi @forthommel great to see this. On our CMS side, we will have a new CMSSW version built only on monday, so if you think this can go in, that would be great. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the single-dissociative LPAIR process implementation is properly handling the
symmetriseflag, to properly mirror inzcoordinate the outgoing central+beam remnants systems, as well as the intermediate partons.It also introduces a test case for the correctness of the factor 2 introduced when symmetrising the SD case.
As a result, the symmetrisation was also introduced in all factorised processes (which can now also be tested alongside).
FYI: @bbilin
Fixes #78