Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognise CentOS 7 as a flavour of RHEL7. #221

Closed
wants to merge 2 commits into from

Conversation

aalba6675
Copy link

Added version string recognition 7.0.1406 as rhel7.

Added version string recognition 7.0.1406 as rhel7.
@dmick
Copy link
Member

dmick commented Nov 20, 2014

We don't want to add part of the "build on centos7" solution; if this is literally all it takes to make complete working packages, then I'm all for it, but...

Also, we shouldn't call it rhel7 when it's not; recognizing and passing on centos7, or el7, or something, would be better.

@aalba6675
Copy link
Author

I know :-( it's an awful hack. Just rushed it out to vagrantup on a CentOS
7 box instead of rhel7.

I will look closer at returning el7. By convention some packagers put in a
centos.el7 tag in the rpm name too instead of just el7.

On Friday, 21 November 2014, Dan Mick notifications@github.com wrote:

We don't want to add part of the "build on centos7" solution; if this is
literally all it takes to make complete working packages, then I'm all for
it, but...

Also, we shouldn't call it rhel7 when it's not; recognizing and passing on
centos7, or el7, or something, would be better.


Reply to this email directly or view it on GitHub
#221 (comment).

@dmick
Copy link
Member

dmick commented Dec 5, 2014

See http://tracker.ceph.com/issues/10256 for some ideas about how I'd rather approach this.

@dmick dmick closed this Dec 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants