Make get-flavor.sh more general #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior code handles OS version case by case. When using CentOS 6.6 or some other versions, rpm-build.sh would fail.
|
Actually I have checked this script under centos7, under which I have to install redhat-lsb to run it, and the version returned by |
|
Right, but, it will claim that Centos7 is rhel7, which is not right. It's not even clear that rhel needs to be different from el, but given that it is, it should at least be consistent. |
|
You mean there should be |
|
See http://tracker.ceph.com/issues/10256 for some ideas about the way I'd rather approach this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior code handles OS version case by case. When using CentOS 6.6 or some other versions, rpm-build.sh would fail.