Add /cluster/<fsid>/{pool/<id>/}stats endpoints #494
Conversation
| def cluster_stats(cluster_name): | ||
| import rados | ||
|
|
||
| cluster = rados.Rados(name=RADOS_NAME, clustername=cluster_name, conffile='') |
There was a problem hiding this comment.
Use a context manager like
to prevent memory leaks. mon_remote.py is long-running code| except Exception as e: | ||
| raise RuntimeError("pool lookup: " + str(e)) | ||
|
|
||
| result = cluster.open_ioctx(pool).get_stats() |
There was a problem hiding this comment.
@b-ranto be sure to close this http://docs.ceph.com/docs/master/rados/api/python/#input-output-context
| return result | ||
|
|
||
|
|
||
| def pool_stats(cluster_name, pool_id): |
There was a problem hiding this comment.
@b-ranto I'd like to building up of a data structure that could be used to support a list-view here. so maybe iterate over http://docs.ceph.com/docs/master/rados/api/python/#rados.Rados.list_pools and return a dict of pool name: stats
| @@ -75,6 +75,11 @@ | |||
| 'patch': 'update', | |||
| 'delete': 'destroy'}), | |||
| name='cluster-pool-detail'), | |||
| url(r'^cluster/(?P<fsid>[a-zA-Z0-9-]+)/pool/(?P<pool_id>\d+)/stats$', | |||
There was a problem hiding this comment.
@b-ranto please add a list view at /api/cluster/FSID/pool/stats you're almost there
The commit adds two stats endpoints that provide global cluster as well per pool statistics. Signed-off-by: Boris Ranto <branto@redhat.com>
b-ranto
force-pushed
the
wip-1.4-rados-native
branch
from
8914757
to
096e722
Compare
|
I've rebased and repushed the commit that should cover the comments. I did use a somehow different layout for pool/stats endpoint since I did not manage to get the serializers to do it the suggested way. |
The commit adds two stats endpoints that provide global cluster as well
per pool statistics.
Signed-off-by: Boris Ranto branto@redhat.com