Skip to content

Commit

Permalink
flake8: fix pep8 syntax on tests/functional/tests/
Browse files Browse the repository at this point in the history
tests/conftest.py and tests present in tests/functional/tests/ has been
missed from previous commit

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
  • Loading branch information
guits committed Oct 6, 2020
1 parent c960362 commit 8596f1d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/flake8.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
python-version: 3.8
architecture: x64
- run: pip install flake8
- run: flake8 --max-line-length 160 ./library/ ./tests/library/
- run: flake8 --max-line-length 160 ./library/ ./tests/library/ ./tests/conftest.py ./tests/functional/tests/
3 changes: 2 additions & 1 deletion tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ def str_to_bool(val):
else:
raise ValueError("Invalid input value: %s" % val)


@pytest.fixture(scope="module")
def setup(host):
cluster_address = ""
Expand All @@ -27,7 +28,6 @@ def setup(host):
container_binary = ansible_vars.get("container_binary", "")
osd_auto_discovery = ansible_vars.get("osd_auto_discovery")
group_names = ansible_vars["group_names"]
fsid = ansible_vars.get("fsid")

ansible_distribution = ansible_facts["ansible_facts"]["ansible_distribution"]

Expand Down Expand Up @@ -82,6 +82,7 @@ def setup(host):

return data


@pytest.fixture()
def node(host, request):
"""
Expand Down
3 changes: 2 additions & 1 deletion tests/functional/tests/test_install.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def test_mon_host_line_has_correct_value(self, node, host, setup):
result = False
assert result


class TestCephCrash(object):
@pytest.mark.no_docker
@pytest.mark.ceph_crash
Expand All @@ -43,4 +44,4 @@ def test_ceph_crash_service_enabled_and_running(self, node, host):
def test_ceph_crash_service_enabled_and_running_container(self, node, host):
s = host.service("ceph-crash@{hostname}".format(hostname=node["vars"]["inventory_hostname"]))
assert s.is_enabled
assert s.is_running
assert s.is_running

0 comments on commit 8596f1d

Please sign in to comment.