Skip to content

Commit

Permalink
container: remove container_binding_name variable
Browse files Browse the repository at this point in the history
The container_binding_name package was only mandatory when we were
using the docker modules (docker_image and docker_container) but since
we manage both docker and podman containers without using the dedicated
module then we can remove it.

Signed-off-by: Dimitri Savineau <dsavinea@redhat.com>
  • Loading branch information
dsavineau authored and guits committed Oct 14, 2020
1 parent 4eaa65c commit 9252b75
Show file tree
Hide file tree
Showing 7 changed files with 1 addition and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

- name: install container packages
package:
name: ['{{ container_package_name }}', '{{ container_binding_name }}']
name: '{{ container_package_name }}'
update_cache: true
register: result
until: result is succeeded
Expand Down
1 change: 0 additions & 1 deletion roles/ceph-container-engine/vars/Debian.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
container_package_name: docker-ce
container_service_name: docker
container_binding_name: python-docker
1 change: 0 additions & 1 deletion roles/ceph-container-engine/vars/RedHat-8.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
container_package_name: podman
container_service_name: podman
container_binding_name: podman
1 change: 0 additions & 1 deletion roles/ceph-container-engine/vars/RedHat.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
container_package_name: docker
container_service_name: docker
container_binding_name: python-docker-py
1 change: 0 additions & 1 deletion roles/ceph-container-engine/vars/Ubuntu-16.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
container_package_name: docker.io
container_service_name: docker
container_binding_name: python-docker
1 change: 0 additions & 1 deletion roles/ceph-container-engine/vars/Ubuntu-18.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
container_package_name: docker.io
container_service_name: docker
container_binding_name: python3-docker
1 change: 0 additions & 1 deletion roles/ceph-container-engine/vars/Ubuntu-20.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
---
container_package_name: docker.io
container_service_name: docker
container_binding_name: python3-docker

0 comments on commit 9252b75

Please sign in to comment.