library: remove unused module import

Move the import at the top of the file and remove unused module import. - E402 module level import not at top of file - F401 'xxxx' imported but unused This also removes the '# noqa E402' statement from the code. Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> (cherry picked from commit 2138a00)
ceph · Aug 2, 2021 · 9ee4401 · 9ee4401
1 parent c475d84
commit 9ee4401
Show file tree

Hide file tree

Showing 9 changed files with 44 additions and 63 deletions.
diff --git a/library/ceph_dashboard_user.py b/library/ceph_dashboard_user.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -103,13 +108,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image, interactive=False):
     '''

diff --git a/library/ceph_fs.py b/library/ceph_fs.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -91,13 +96,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_key.py b/library/ceph_key.py
@@ -17,6 +17,15 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+import struct
+import time
+import base64
+import socket
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -175,17 +184,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import grp  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import pwd  # noqa: E402
-import stat  # noqa: E402
-import struct  # noqa: E402
-import time  # noqa: E402
-import base64  # noqa: E402
-import socket  # noqa: E402
 
 CEPH_INITIAL_KEYS = ['client.admin', 'client.bootstrap-mds', 'client.bootstrap-mgr',  # noqa: E501
                      'client.bootstrap-osd', 'client.bootstrap-rbd', 'client.bootstrap-rbd-mirror', 'client.bootstrap-rgw']  # noqa: E501

diff --git a/library/ceph_pool.py b/library/ceph_pool.py
@@ -17,6 +17,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -135,13 +140,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/ceph_volume.py b/library/ceph_volume.py
@@ -1,5 +1,6 @@
 #!/usr/bin/python
 
+from ansible.module_utils.basic import AnsibleModule
 import datetime
 import copy
 import json
@@ -185,9 +186,6 @@
 '''
 
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-
-
 def fatal(message, module):
     '''
     Report a fatal error and exit

diff --git a/library/radosgw_realm.py b/library/radosgw_realm.py
@@ -15,6 +15,10 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -81,13 +85,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_user.py b/library/radosgw_user.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -129,13 +134,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''

diff --git a/library/radosgw_zone.py b/library/radosgw_zone.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -114,13 +119,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def fatal(message, module):
     '''

diff --git a/library/radosgw_zonegroup.py b/library/radosgw_zonegroup.py
@@ -15,6 +15,11 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
 
+from ansible.module_utils.basic import AnsibleModule
+import datetime
+import json
+import os
+
 
 ANSIBLE_METADATA = {
     'metadata_version': '1.1',
@@ -101,13 +106,6 @@
 
 RETURN = '''#  '''
 
-from ansible.module_utils.basic import AnsibleModule  # noqa: E402
-import datetime  # noqa: E402
-import json  # noqa: E402
-import os  # noqa: E402
-import stat  # noqa: E402
-import time  # noqa: E402
-
 
 def container_exec(binary, container_image):
     '''