ceph-validate: check devices from lvm_volumes

2888c08 introduced a regression as the check_devices tasks file was only included based on the devices variable. But that file also validate some devices from the lvm_volumes variable. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1906022 Signed-off-by: Dimitri Savineau <dsavinea@redhat.com> (cherry picked from commit ac0342b)
ceph · Jul 2, 2021 · a3b5b15 · a3b5b15
1 parent 6bda641
commit a3b5b15
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/roles/ceph-validate/tasks/check_devices.yml b/roles/ceph-validate/tasks/check_devices.yml
@@ -83,7 +83,7 @@
         unit: MiB
       register: devices_parted
       failed_when: False
-      with_items: "{{ devices }}"
+      with_items: "{{ devices | default([]) }}"
 
     - name: fail if one of the devices is not a device
       fail:

diff --git a/roles/ceph-validate/tasks/main.yml b/roles/ceph-validate/tasks/main.yml
@@ -152,7 +152,6 @@
   when:
     - osd_group_name in group_names
     - not osd_auto_discovery | default(False) | bool
-    - devices|default([])|length > 0
 
 - name: include check_eth_mon.yml
   include_tasks: check_eth_mon.yml