Skip to content

Commit

Permalink
osd: support changing default rule even when osd_crush_location isn't…
Browse files Browse the repository at this point in the history
… defined

Creating crush rules even with no crush hierarchy configuration is a
valid scenario so we shouldn't be bound to the first task result (which
configure crush hierarchy) to be able to add new crush rules.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1816989

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
(cherry picked from commit 5b04763)
  • Loading branch information
guits committed Mar 31, 2020
1 parent 586c6e8 commit d4ffe21
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions roles/ceph-osd/tasks/crush_rules.yml
Expand Up @@ -43,7 +43,6 @@
with_items: "{{ groups[mon_group_name] }}"
run_once: true
when:
- not config_crush_hierarchy.get('skipped', false)
- info_ceph_default_crush_rule_yaml | default('') | length > 0
- not containerized_deployment | bool

Expand All @@ -68,5 +67,4 @@
with_items: "{{ groups[mon_group_name] }}"
run_once: true
when:
- not config_crush_hierarchy.get('skipped', false)
- info_ceph_default_crush_rule_yaml | default('') | length > 0

0 comments on commit d4ffe21

Please sign in to comment.