Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't wait for user confirmation when migrating a cluster to containers #1758

Closed
gfidente opened this issue Aug 10, 2017 · 3 comments
Closed

Don't wait for user confirmation when migrating a cluster to containers #1758

gfidente opened this issue Aug 10, 2017 · 3 comments

Comments

@gfidente
Copy link
Contributor

gfidente commented Aug 10, 2017 •
edited
Loading

Would it be possible to not wait for user confirmation in the switch to containers playbook?

This would be useful when consuming the playbook in TripleO
@guits
Copy link
Collaborator

guits commented Aug 10, 2017 •
edited
Loading

I think we could get rid of this and just change this :

like this:
when: ireallymeanit != 'yes'
to
when: ireallymeanit is not defined and ireallymeanit != 'yes'

obviously updating the error message displayed as well

@andrewschoen any thoughts?

@andrewschoen
Copy link
Contributor

You can get around this by passing --extra-vars "ireallymeanit=yes" to your ansible-playbook command.

We do this for our CI testing of purge-cluster.yml and rolling_update.yml. e.g https://github.com/ceph/ceph-ansible/blob/master/tox.ini#L15

@guits
Copy link
Collaborator

guits commented Aug 10, 2017

thx @andrewschoen, I was not aware of that. Looks there is no issue with that then.

@guits guits closed this as completed Aug 10, 2017
openstack-gerrit pushed a commit to openstack/openstack that referenced this issue Aug 19, 2017
@openstack-gerrit
Updated openstack/openstack
03168b0 
Project: openstack/tripleo-heat-templates  0b7c9a13ef977d50939a9a697c370d2ec26ed4b3

Add params needed for the ceph-ansible switch to containers playbook

Pre existing Ceph clusters are migrated to containers using a
playbook in ceph-ansible which requires setting some 'ireallymeanit'
variable.

1. ceph/ceph-ansible#1758

Change-Id: I5c2f46b91cf032913931275ce62315f293f21c8b
Closes-Bug: #1711159
openstack-gerrit pushed a commit to openstack-archive/tripleo-heat-templates that referenced this issue Aug 19, 2017
@gfidente
Add params needed for the ceph-ansible switch to containers playbook
bf85126 
Pre existing Ceph clusters are migrated to containers using a
playbook in ceph-ansible which requires setting some 'ireallymeanit'
variable.

1. ceph/ceph-ansible#1758

Change-Id: I5c2f46b91cf032913931275ce62315f293f21c8b
Closes-Bug: #1711159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrewschoen @gfidente @guits