Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: set apt pinning with Red Hat Ceph Storage #1186

Merged
merged 2 commits into from Dec 15, 2016
Merged

common: set apt pinning with Red Hat Ceph Storage #1186

merged 2 commits into from Dec 15, 2016

Conversation

leseb
Copy link
Member

@leseb leseb commented Dec 14, 2016

When ceph_stable_rh_storage is True, every cluster node should have a
/etc/apt/preferences.d/rhcs.pref file with the following contents:

Explanation: Prefer Red Hat packages
Package: *
Pin: release o=/Red Hat/
Pin-Priority: 999

ceph-deploy already did this when used with ice-setup, and we need to do
the same thing with the ceph-ansible stack.

Closes: #1182

Signed-off-by: Sébastien Han seb@redhat.com

@leseb
Copy link
Member Author

leseb commented Dec 14, 2016

@ktdreyer

@ktdreyer
Copy link
Member

There are some changes to name: in here, that would make this change harder to cherry-pick, if we had to do a cherry-pick. Want to break those out into a separate commit?

@leseb
Copy link
Member Author

leseb commented Dec 14, 2016

@ktdreyer yes that'd be better :)

When `ceph_stable_rh_storage` is True, every cluster node should have a
`/etc/apt/preferences.d/rhcs.pref` file with the following contents:

```
Explanation: Prefer Red Hat packages
Package: *
Pin: release o=/Red Hat/
Pin-Priority: 999
```

ceph-deploy already did this when used with ice-setup, and we need to do
the same thing with the ceph-ansible stack.

Closes: #1182 and https://bugzilla.redhat.com/show_bug.cgi?id=1404515

Signed-off-by: Sébastien Han <seb@redhat.com>
We do not need to run another condition for 'ceph_rhcs' since the
include we came from already has it, so we are already inside this
condition.
We also spell red hat entirely instead of rh and we remove capital
letters.

Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
Copy link
Member Author

leseb commented Dec 14, 2016

@ktdreyer done!

Copy link
Member

@ktdreyer ktdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@andrewschoen
Copy link
Contributor

jenkins test ansible2.2-docker_cluster

@leseb leseb merged commit 245a556 into master Dec 15, 2016
@leseb leseb deleted the apt-pining branch December 15, 2016 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants