Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport: mon: fix with_items being evaluated before when #1567

Merged
merged 1 commit into from May 24, 2017
Merged

backport: mon: fix with_items being evaluated before when #1567

merged 1 commit into from May 24, 2017

Conversation

leseb
Copy link
Member

@leseb leseb commented May 24, 2017

Ansible evaluates the 'with_items' before the 'when' so if the inventory
does not have the group declared it'll fail. To fix this, we set an
empty array to make the with_items happy and then evaluate with the
'when'.

Signed-off-by: Sébastien Han seb@redhat.com
(cherry picked from commit 05331a2)
Signed-off-by: Sébastien Han seb@redhat.com

@leseb
mon: fix with_items being evaluated before when
4bd9bea 
Ansible evaluates the 'with_items' before the 'when' so if the inventory
does not have the group declared it'll fail. To fix this, we set an
empty array to make the with_items happy and then evaluate with the
'when'.

Signed-off-by: Sébastien Han <seb@redhat.com>
(cherry picked from commit 05331a2)
Signed-off-by: Sébastien Han <seb@redhat.com>
@leseb
Copy link
Member Author

leseb commented May 24, 2017

backport of #1428

@leseb leseb changed the title mon: fix with_items being evaluated before when backport: mon: fix with_items being evaluated before when May 24, 2017
@andrewschoen
Copy link
Contributor

jenkins test jewel-ansible2.2-dmcrypt_journal

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-journal_collocation

1 similar comment
@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-journal_collocation

@andrewschoen
Copy link
Contributor

jenkins test jewel-ansible2.2-dmcrypt_journal_collocation

@andrewschoen
Copy link
Contributor

jenkins test jewel-ansible2.2-docker_cluster

@andrewschoen
Copy link
Contributor

jenkins test jewel-ansible2.2-docker_dmcrypt_journal_collocation

@andrewschoen
Copy link
Contributor

jenkins test jewel-ansible2.2-purge_dmcrypt

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-centos7_cluster

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-dmcrypt_journal_collocation

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-docker_dedicated_journal

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-dmcrypt_journal_collocation

@ktdreyer
Copy link
Member

What BZ does this resolve?

What is the risk of not taking this fix now?

@leseb
Copy link
Member Author

leseb commented May 24, 2017

@ktdreyer this is no BZ for this yet, risk is low.

@andrewschoen
Copy link
Contributor

@ktdreyer The risk is that containers fail to deploy. We see this failure consistently in our nightly ceph-docker tests that use stable-2.2

https://jenkins.ceph.com/view/ceph-docker/job/ceph-docker-nightly-ceph_ansible2.2-jewel-centos7-cluster/9/console

ktdreyer
ktdreyer requested changes May 24, 2017
View reviewed changes
Copy link
Member

@ktdreyer ktdreyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please file a BZ with "Steps to reproduce", "Actual results", "Expected results", so QE understands why we would change this and how to test it?

What is the exact impact to users if we do not ship this?

@andrewschoen
Copy link
Contributor

BZ https://bugzilla.redhat.com/show_bug.cgi?id=1455266

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-dmcrypt_journal_collocation

2 similar comments
@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-dmcrypt_journal_collocation

@andrewschoen
Copy link
Contributor

jenkins test kraken-ansible2.2-dmcrypt_journal_collocation

@andrewschoen andrewschoen merged commit 3b622ae into stable-2.2 May 24, 2017
@ktdreyer ktdreyer deleted the fix-mgr-bkp branch May 24, 2017 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktdreyer ktdreyer ktdreyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@leseb @andrewschoen @ktdreyer