lvm-osds: test with a partition and an lv as journals #1841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This also updates the tests Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
But only for the first partition, so that a new label doesn't blow away the previous partition created Signed-off-by: Alfredo Deza <adeza@redhat.com>
|
I ran a successful test here using the wip branch from ceph for the ceph-volume changes: https://2.jenkins.ceph.com/job/ceph-ansible-scenario/12/console This is the corresponding PR for ceph.git ceph/ceph#17403 |
alfredodeza
approved these changes
Aug 31, 2017
|
The CI failures here are unrelated to this PR. I'm going to merge so we can get ceph/ceph#17403 tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support to the lvm_journals scenario so that you can use an lv for a journal. It also modifies the test so that it uses a partition for the other journal instead of a raw device, as ceph-volume is changing to not allow raw devices for journals.