defaults: do not restart unconfigured (yet) daemons #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
changed the title
|
I still need to check the right name of some sockets. |
guits
approved these changes
Sep 8, 2017
leseb
force-pushed
the
handler-collocate
branch
2 times, most recently
from
42ebd4e
to
cdf7659
Compare
In a collocated scenario, where you might put a rgw, a mds and a mon on the same node you don't want the handler blindly restart all the daemons on the node. Indeed some of them might not be configured yet. Implementing a more precise socket detection, for each daemon type. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1488813 Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
handler-collocate
branch
from
cdf7659
to
12f6e53
Compare
Rename this fact to keep consistency with handlers in `ceph-defaults`. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
jenkins test luminous-ansible2.3-bluestore_dmcrypt_journal |
|
jenkins test luminous-ansible2.3-docker_dmcrypt_journal_collocation |
|
jenkins test luminous-ansible2.3-shrink_mon |
|
Testing: luminous-ansible2.3-bluestore_docker_dmcrypt_journal_collocation — FAIL - luminous-ansible2.3-bluestore_docker_dmcrypt_journal_collocation |
leseb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a collocated scenario, where you might put a rgw, a mds and a mon on
the same node you don't want the handler blindly restart all the daemons
on the node. Indeed some of them might not be configured yet.
Implementing a more precise socket detection, for each daemon type.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1488813
Signed-off-by: Sébastien Han seb@redhat.com