rpm: ship rhcs.yaml.sample as all.yml.sample on RHEL #1900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the RPM on RHEL, we will ship the conents of the `rhcs.yml.sample` file into `all.yml.sample`. The purpose of this change is to expose "all.yml.sample" to both upstream and downstream users, so they use the same file name (but with different contents.)
vasukulkarni
approved these changes
Sep 14, 2017
|
This is just another thing that downstream needs to carry over, adding more confusion to any user that wants to just consume this as-is. A simple diff on those files is just changing 3 variables. Why are we maintaining this in this way? Why is it necessary to carry almost 500 lines over to another file where only 3 lines are changing? How can we make it simpler? |
|
@alfredodeza we could make this easier but the release is approaching and we don't have much time to spend on this. We will address this in the next one. |
leseb
approved these changes
Sep 18, 2017
leseb
reviewed
Sep 18, 2017
| rm group_vars/all.yml.sample | ||
| %if ! 0%{?fedora} && ! 0%{?centos} | ||
| # Ship only the Red Hat Ceph Storage config (overwrite upstream settings) | ||
| cp group_vars/rhcs.yml.sample group_vars/all.yml.sample |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the RPM on RHEL, we will ship the conents of the
rhcs.yml.samplefile intoall.yml.sample.The purpose of this change is to expose "all.yml.sample" to both upstream and downstream users, so they use the same file name (but with different contents.)