Dont run client dummy container on ppc64le hosts #3084
Conversation
|
RHBZ#1624216 |
|
Works for me! |
| groups: _filtered_clients | ||
| with_items: "{{ groups[client_group_name] }}" | ||
| when: | ||
| - hostvars[item]['ansible_architecture'] != 'ppc64le' |
There was a problem hiding this comment.
I wonder if it's worth expressing this as:
- hostvars[item]['ansible_architecture'] == 'x86_64'
that way if someone tries to do the client setup on aarch64 they don't run into the same issue.
|
Works for me, I can add in to specify only x86_64 instead. |
The dummy client container currently wont work on non-x86_64 hosts. This PR creates a filtered client group that contains only hosts that are x86_64 - which can then be the group to run the dummy container against. This is for the specific case of a containerized_deployment where there is a mixture of non-x86_64 hosts and x86_64 hosts. As such the filtered group will contain all hosts when running with containerized_deployment: false. Currently ppc64le is not supported for Ceph server components. Signed-off-by: Andy McCrae <andy.mccrae@gmail.com>
|
@andymcc typically in a fully containerized env, clients do not have any package manager. So to get the binary they need a container. |
|
Ok fixed that up - I made one additional change, which is that if you are running iwith containerized_deployment: false - it won't try filter the list and will instead just add all hosts in to the filtered group. That'll mean a use-case where you have ppc64le clients only - but are not running in containerized_deployment mode, it wont filter those hosts out and will run normally. |
|
@leseb - ahh ok - and there isn't a container that is just the client binaries? |
| groups: _filtered_clients | ||
| with_items: "{{ groups[client_group_name] }}" | ||
| when: | ||
| - (hostvars[item]['ansible_architecture'] == 'x86_64') or (not containerized_deployment) |
There was a problem hiding this comment.
Shouldn't this be?
when:
- containerized_deployment
- hostvars[item]['ansible_architecture'] == 'x86_64'
There was a problem hiding this comment.
@leseb - i think that would create a situation where on containerized_deployment: false that the filtered_clients group contains no hosts, we want the opposite which is when containerized_deployment is false or its an x86_64 host, then add it to the group.
There was a problem hiding this comment.
Good point, can't we then do something like groups.get('_filtered_clients', 'client_group_name')? So if _filtered_clients does not exist we use client_group_name?
There was a problem hiding this comment.
We could - but it makes line 130 difficult because we reference host [0] in the group, rather than using groups.get.
If it's not containerized_deployment groups['_filtered_clients'] would be the same as groups[client_group_name] - so im not sure its necessary.
There was a problem hiding this comment.
You're right, your approach is much easier in the end.
|
@andymcc no dedicated container for the binaries only, just the same one. This was a quick and dirty solution which I hope will disappear for 3.2. Actually, 2 PRs have code to remove that dependency already, I just need to resurrect them :). |
|
@leseb - ahh nice! That makes sense. Thanks for the update, I figured it wasn't a permanent fix. |
The dummy client container currently wont work on ppc64le hosts.
This PR creates a filtered client group that contains only hosts
that are not ppc64le - which can then be the group to run the
dummy container against.
This is for the specific case of a containerized_deployment where
there is a mixture of non-ppc64le hosts and ppc64le hosts.
Currently ppc64le is not supported with Ceph server components.
Signed-off-by: Andy McCrae andy.mccrae@gmail.com