Add new container scenario #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
force-pushed
the
podman-support
branch
2 times, most recently
from
d54dcef
to
effa73b
Compare
|
jenkins test dev-container_podman |
1 similar comment
|
jenkins test dev-container_podman |
|
jenkins test pipeline |
leseb
changed the title
leseb
force-pushed
the
podman-support
branch
2 times, most recently
from
e67555c
to
44807bb
Compare
leseb
changed the title
leseb
changed the title
leseb
changed the title
|
jenkins test dev-container_podman |
leseb
changed the title
leseb
force-pushed
the
podman-support
branch
from
44807bb
to
b7c5fb2
Compare
leseb
changed the title
Test with podman instead of docker and also support for python 3 only. Signed-off-by: Sébastien Han <seb@redhat.com>
Since 84fcf4639140c390a7f1fcd790ba190503713f86 we now use the container binary cli to create ceph keys instead of creating a container and 'docker execing' into it. Signed-off-by: Sébastien Han <seb@redhat.com>
Rework all the ceph_key invocation to use either docker or podman binary. Signed-off-by: Sébastien Han <seb@redhat.com>
The support of set-uid was remove from Ceph during the Nautilus cycle by the following commit: d6def8ba1126209f8dcb40e296977dc2b09a376e so this will not work anymore when deploying Nautilus clusters and above. Signed-off-by: Sébastien Han <seb@redhat.com>
The entity name is client.bootstrap-osd (as returned by Ceph), and not bootstrap-osd. The build_key_path function split 'client.bootstrap-osd' on the '.' so using bootstrap-osd fails with index out of range. Signed-off-by: Sébastien Han <seb@redhat.com>
The previous dict was missing 2 entities: * client.bootstrap-mgr * client.bootstrap-rbd-mirror So the test was failing since it expects 7 entities to match. Signed-off-by: Sébastien Han <seb@redhat.com>
Removing bytes literals since rstrip only supports type String or None. Signed-off-by: Sébastien Han <seb@redhat.com>
Since we are now testing on docker and podman our functionnal tests must reflect that. So now, if we detect the podman binary we will use it, otherwise we default to docker. Signed-off-by: Sébastien Han <seb@redhat.com>
Make flake8 happy on the testinfra files. Signed-off-by: Sébastien Han <seb@redhat.com>
During its initialisation both rbd-target-api and rbd-target-gw try to open /dev/log for their syslog handler. If the device is not present the service fails to start. Thus expose /dev/log from the host in the container solves that problem. Signed-off-by: Sébastien Han <seb@redhat.com>
We need to verify wether podman exists or not, if yes we use it instead of docker. Signed-off-by: Sébastien Han <seb@redhat.com>
Use podman or docker wether they are available or not. podman will be prioritized over docker if present. Signed-off-by: Sébastien Han <seb@redhat.com>
Use the new way to create keys on containerized env as introduced by: 1098b71 Signed-off-by: Sébastien Han <seb@redhat.com>
We deprecated site-docker to site-container so let's have a symlink for backward compatibility. Signed-off-by: Sébastien Han <seb@redhat.com>
It seems Atomic 7.5 has podman already, however this is an old version (0.4). The podman integration is targetting RHEL 8, so Fedora is currently the closest to that. Signed-off-by: Sébastien Han <seb@redhat.com>
Always declare container_binary and assign it a correct value. Signed-off-by: Sébastien Han <seb@redhat.com>
This is not needed to play these tasks on nodes that are not in rgw
group.
Always playing this code makes `shrink_mon.yml` failing.
Typical error:
```
TASK [ceph-defaults : set_fact _radosgw_address to radosgw_interface - ipv4] ***
task path: /home/jenkins-build/build/workspace/ceph-ansible-prs-dev-shrink_mon/roles/ceph-defaults/tasks/set_radosgw_address.yml:21
Thursday 22 November 2018 12:34:51 +0000 (0:00:00.154) 0:00:12.371 *****
fatal: [localhost]: FAILED! => {}
MSG:
The task includes an option with an undefined variable. The error was: 'ansible.vars.hostvars.HostVarsVars object' has no attribute u'ansible_eth1'
```
Indeed, `radosgw_interface` is the network interface on rgw only. It is
expected that this same interface doesn't exist on `localhost`, so, when
running `shrink_mon.yml`, the role `ceph-defaults` is called in
`hosts: localhost` and causes the playbook to fail.
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
We need to add the right binary to do the docker exec. Signed-off-by: Sébastien Han <seb@redhat.com>
ntp is installation is managed by the ceph-infra role. Signed-off-by: Sébastien Han <seb@redhat.com>
Position the right condition on ceph_docker_version, activate it when the container_binary is 'docker'. Signed-off-by: Sébastien Han <seb@redhat.com>
Fix the tests Signed-off-by: Sébastien Han <seb@redhat.com>
Signed-off-by: Sébastien Han <seb@redhat.com>
leseb
force-pushed
the
podman-support
branch
from
0de0d5e
to
0b1aa7e
Compare
|
jenkins test dev-docker_cluster |
|
jenkins test dev-centos7_cluster |
guits
approved these changes
Nov 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test with podman instead of docker and also support for python 3 only.
Signed-off-by: Sébastien Han seb@redhat.com