Automatic backport of pull request #3837 #3850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
We don't support the preparation of OSD with ceph-disk. ceph-volume is only supported. However, the start operation of OSD is still supported. So let's say you change a config option, the handlers will be able to restart all the OSDs via their respective systemd unit files. Signed-off-by: Sébastien Han <seb@redhat.com> Co-authored-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit e2a5aa0)
ceph-disk is not supported anymore, so all the newly created OSDs will be configured using ceph-volume. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 9ea1e49)
osd_scenario has become obsolete and defaults to lvm. With lvm there is no such things has collocated and non-collocated. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 52df158)
This commits adds documentation for the lvm scenario and the deprecation of collocated and non-collocated scenario. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit f8e1542)
Make python linter happy. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit e246727)
osd_scenario now defaults to lvm and should not be changed. So we don't need to test it. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 72211d4)
We only validate the devices that are passed if there is a list of devices to validate. Signed-off-by: Sébastien Han <seb@redhat.com> (cherry picked from commit 2888c08)
ceph_disk_cli_options_facts.yml is not used anymore, let's remove it. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 4d5637f)
guits
force-pushed
the
mergify/bp/stable-4.0/pr-3837
branch
from
8297210
to
1051793
Compare
As of stable-4.0, the only valid scenario is `lvm`. Thus, this makes this variable useless. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 4d35e9e)
This variable was related to ceph-disk scenarios. Since we are entirely dropping ceph-disk support as of stable-4.0, let's remove this variable. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit f0416c8)
these files aren't needed anymore since we only use lvm scenario. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 4f68462)
this test is related to ceph-disk which is dropped as of stable-4.0 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 83e84c6)
we must pass the value of osd_scenario from the stable-3.2 branch which is used for the initial deployment. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 3519281)
this file is not used anymore, let's remove it. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit f899da3)
as of stable-4.0, ceph-disk is no longer supported. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit e6bfb84)
as of stable-4.0, ceph-disk is no longer supported. Let's remove this legacy version of the playbook. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit 73aa788)
as of stable-4.0, ceph-disk is no longer supported. These tasks aren't needed anymore. Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com> (cherry picked from commit a1254d7)
guits
force-pushed
the
mergify/bp/stable-4.0/pr-3837
branch
from
1051793
to
4789894
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #3837 done by Mergify.io