New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add radosgw_frontend_ssl_certificate parameter #4130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add the Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1721914
statement in the commit body ?
Also I'm wondering if we could do both ssl implementation in the same time instead of civetweb only. wdyt ?
3c231bb
to
9417b0f
Compare
The jinja template still fails. |
Nevermind, I didn't read the documentation correctly. So it's fine with only one combined file for both civetweb and beast |
Do we need to backport this to |
@ktdreyer According to https://bugzilla.redhat.com/show_bug.cgi?id=1722071 yes |
@gfidente the code looks good but there's some part missing
[1] https://github.com/ceph/ceph-ansible/blob/master/roles/ceph-rgw/templates/ceph-radosgw.service.j2#L31-L33 |
@dsavineau thanks for the review, will do |
This is necessary when configuring RGW with SSL because in addition to passing specific frontend options, civetweb appends the 's' character to the binding port and beast uses ssl_endpoint instead of endpoint. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1722071 Signed-off-by: Giulio Fidente <gfidente@redhat.com>
jenkins test pipeline |
mergify failed to merge, doing it manually |
This is necessary when configuring RGW/civetweb with SSL because
in addition to passing a specific frontend option, we need to
append the 's' character to the binding port.
Signed-off-by: Giulio Fidente gfidente@redhat.com