New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust openstack_keys #4329
Adjust openstack_keys #4329
Conversation
retest this please |
2 similar comments
retest this please |
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, thanks for your submission
can you please amend the class-read addition?
retest this please |
@logan2211 from what I read here, I understand @noonedeadpunk should set back the |
@logan2211 thanks for stepping in and describing the problem in details (while I was really missing them) |
@noonedeadpunk sounds good to me |
retest this please |
Considering the previous implementation matched what was suggested in ceph docs at [1], maybe this should trigger a change in the docs as well? |
Placed ceph/ceph#29865 to update docs |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@guits I thought we wanted this one in? |
Rebased on top of the master just in case |
@noonedeadpunk Could you amend your commit message ? because it's mentioned cinder & glance but the code is only modifying the cinder caps. |
Added missing class-read object_prefix rbd_children to glance so that they can unprotect images. As these permissions should be set globally on cluster but not only on the specific pool, we need to add them explicitly. Also since glance do not need write access to volumes pool and set permission is static (do not rely on openstack_cinder_pool) we can easily drop it. Signed-off-by: Dmitriy Rabotyagov <drabotyagov@vexxhost.com>
@dsavineau Good catch, as I've lost volumes permission drop during rebase. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
retest this please |
jenkins test centos-container-all_daemons |
jenkins test centos-container-update |
jenkins test centos-container-purge |
https://docs.ceph.com/ceph-ansible/master/dev/index.html#pull-request-testing
What new deployment system are you talking about ? |
@dsavineau I was talking about ceph orchestrator, which is going to replace ceph-deploy, ceph-ansible, etc in octopus |
AFAIK ceph-ansible will still be there for octopus |
correct |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Since glance do not need write access to volumes pool and
set permission is static (do not rely on openstack_cinder_pool)
we can easily drop it.
Also as glance do not need write access to volumes pool and
set permission is static (do not rely on openstack_cinder_pool)
we can easily drop it.