Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust openstack_keys #4329

Closed
wants to merge 3 commits into from
Closed

Adjust openstack_keys #4329

wants to merge 3 commits into from

Conversation

noonedeadpunk
Copy link
Contributor

@noonedeadpunk noonedeadpunk commented Aug 12, 2019

Since glance do not need write access to volumes pool and
set permission is static (do not rely on openstack_cinder_pool)
we can easily drop it.

Also as glance do not need write access to volumes pool and
set permission is static (do not rely on openstack_cinder_pool)
we can easily drop it.

@noonedeadpunk
Copy link
Contributor Author

retest this please

2 similar comments
@noonedeadpunk
Copy link
Contributor Author

retest this please

@noonedeadpunk
Copy link
Contributor Author

retest this please

@guits
Copy link
Collaborator

guits commented Aug 14, 2019

@gfidente @fultonj @fmount

Copy link
Contributor

@gfidente gfidente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, thanks for your submission

can you please amend the class-read addition?

group_vars/all.yml.sample Outdated Show resolved Hide resolved
group_vars/all.yml.sample Outdated Show resolved Hide resolved
@noonedeadpunk
Copy link
Contributor Author

retest this please

@noonedeadpunk noonedeadpunk changed the title Adjust openstack keys Remove volume permissions for glance Aug 15, 2019
@guits
Copy link
Collaborator

guits commented Aug 20, 2019

@logan2211 from what I read here, I understand @noonedeadpunk should set back the class-read object_prefix rbd_children permission on this patch?

@noonedeadpunk noonedeadpunk changed the title Remove volume permissions for glance Adjust openstack_keys Aug 20, 2019
@noonedeadpunk
Copy link
Contributor Author

@logan2211 thanks for stepping in and describing the problem in details (while I was really missing them)
@guits I've returned object_prefix rbd_children

@guits
Copy link
Collaborator

guits commented Aug 20, 2019

@noonedeadpunk sounds good to me
@logan2211 thanks, I think it's pretty clear for everyone unless @gfidente has something different to share?

@noonedeadpunk
Copy link
Contributor Author

retest this please

@gfidente
Copy link
Contributor

Considering the previous implementation matched what was suggested in ceph docs at [1], maybe this should trigger a change in the docs as well?

  1. https://docs.ceph.com/docs/master/rbd/rbd-openstack/

@noonedeadpunk
Copy link
Contributor Author

Considering the previous implementation matched what was suggested in ceph docs at [1], maybe this should trigger a change in the docs as well?

  1. https://docs.ceph.com/docs/master/rbd/rbd-openstack/

Placed ceph/ceph#29865 to update docs

@stale
Copy link

stale bot commented Oct 1, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 1, 2019
@gfidente
Copy link
Contributor

gfidente commented Oct 2, 2019

@guits I thought we wanted this one in?

@stale stale bot removed the wontfix label Oct 2, 2019
@noonedeadpunk
Copy link
Contributor Author

noonedeadpunk commented Oct 8, 2019

Rebased on top of the master just in case

@dsavineau
Copy link
Contributor

@noonedeadpunk Could you amend your commit message ? because it's mentioned cinder & glance but the code is only modifying the cinder caps.

Added missing class-read object_prefix rbd_children to glance
so that they can unprotect images. As these permissions should
be set globally on cluster but not only on the specific pool,
we need to add them explicitly.

Also since glance do not need write access to volumes pool and
set permission is static (do not rely on openstack_cinder_pool)
we can easily drop it.

Signed-off-by: Dmitriy Rabotyagov <drabotyagov@vexxhost.com>
@noonedeadpunk
Copy link
Contributor Author

@dsavineau Good catch, as I've lost volumes permission drop during rebase.

@stale
Copy link

stale bot commented Nov 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 28, 2019
@noonedeadpunk
Copy link
Contributor Author

retest this please

@stale stale bot removed the wontfix label Nov 28, 2019
@noonedeadpunk
Copy link
Contributor Author

@guits @gfidente So lot's of time passed since PR submission. Considering that caph-ansible will be sunseted in favor of the new deployment system - does this patch still has any sense?

@dsavineau
Copy link
Contributor

jenkins test centos-container-all_daemons

@dsavineau
Copy link
Contributor

jenkins test centos-container-update

@dsavineau
Copy link
Contributor

jenkins test centos-container-purge

@dsavineau
Copy link
Contributor

retest this please

https://docs.ceph.com/ceph-ansible/master/dev/index.html#pull-request-testing

@guits @gfidente So lot's of time passed since PR submission. Considering that caph-ansible will be sunseted in favor of the new deployment system - does this patch still has any sense?

What new deployment system are you talking about ?

@noonedeadpunk
Copy link
Contributor Author

@dsavineau I was talking about ceph orchestrator, which is going to replace ceph-deploy, ceph-ansible, etc in octopus
https://docs.google.com/presentation/d/1JpcETNXpuB1JEuhX_c8xtgNnv0gJhSaQUffM7aRjUek

@dsavineau
Copy link
Contributor

AFAIK ceph-ansible will still be there for octopus

@guits
Copy link
Collaborator

guits commented Nov 28, 2019

AFAIK ceph-ansible will still be there for octopus

correct

@stale
Copy link

stale bot commented Dec 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 28, 2019
@stale stale bot closed this Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants