ceph_key: restore file mode after a key is fetched #4736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
guits-fix_ceph_key
branch
2 times, most recently
from
0c0f7b1
to
ce230ae
Compare
guits
changed the title
guits
force-pushed
the
guits-fix_ceph_key
branch
from
ce230ae
to
a69beeb
Compare
when `import_key` is enabled, if the key already exists, it will only be fetched using ceph cli, if the mode specified in the `ceph_key` task is different from what is applied by the ceph cli, the mode isn't restored because we don't call `module.set_fs_attributes_if_different()` before `module.exit_json(**result)` Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1734513 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
force-pushed
the
guits-fix_ceph_key
branch
from
a69beeb
to
98dcbd4
Compare
|
jenkins test centos-non_container-all_daemons |
leseb
approved these changes
Nov 14, 2019
This was referenced Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when
import_keyis enabled, if the key already exists, it will only befetched using ceph cli, if the mode specified in the
ceph_keytask isdifferent from what is applied by the ceph cli, the mode isn't restored because
we don't call
module.set_fs_attributes_if_different()beforemodule.exit_json(**result)Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1734513
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com