add-osd: unset noup flag after last osd is deployed #5257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test centos-container-update |
|
jenkins test centos-non_container-external_clients |
|
jenkins test centos-non_container-add_osds |
|
jenkins test centos-container-add_osds |
dsavineau
suggested changes
Apr 7, 2020
this commit fixes a bug when using `add-osd.yml` playbook. `noup` flag is set early but it never got unset before the "wait for pgs clean" check, so the playbook always fails because OSDs aren't never seen UP. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1816023 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
This commit makes this playbook gathering facts from all other nodes but
clients.
When collocating OSDs on other nodes it can fail like following:
```
fatal: [vm252-11]: FAILED! => {
"msg": "'ansible.vars.hostvars.HostVarsVars object' has no attribute 'ansible_hostname'"
}
```
In that case, a fact from a RGW node is called when rendering the
`ceph.conf.j2` but it fails because facts are gathered only from mon and
osd nodes.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1806765
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
dsavineau
approved these changes
Apr 7, 2020
|
jenkins test centos-non_container-add_osds |
|
jenkins test centos-container-add_osds |
There's no need to have two plays anymore since we now set/unset osd flags in `ceph-osd` role. Also, this commit makes the role `ceph-facts` to be called after `ceph-defaults` Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
|
jenkins test centos-non_container-add_osds |
|
jenkins test centos-container-add_osds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit fixes a bug when using
add-osd.ymlplaybook.noupflag is set early but it never got unset before the "wait for pgsclean" check, so the playbook always fails because OSDs aren't never
seen UP.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1816023
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com