[skip ci] fs2bs: skip migration when a mix of fs and bs is detected #6143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guits
force-pushed
the
bz1875777_v2
branch
4 times, most recently
from
6075aad
to
266a31f
Compare
guits
changed the title
|
jenkins test centos-non_container-filestore_to_bluestore |
|
jenkins test centos-container-filestore_to_bluestore |
guits
changed the title
guits
changed the title
|
jenkins test centos-container-filestore_to_bluestore |
guits
changed the title
|
jenkins test centos-container-filestore_to_bluestore |
guits
force-pushed
the
bz1875777_v2
branch
2 times, most recently
from
02c9a4e
to
8a31c72
Compare
guits
commented
Jan 11, 2021
dsavineau
suggested changes
Jan 11, 2021
Since the default of `osd_objectstore` has changed as of 3.2, some deployments might have a mix of filestore and bluestore OSDs on a same node. In some specific cases, there's a possibility that a filestore OSD shares a journal/db device with a bluestore OSD. We shouldn't try to redeploy in this context because ceph-volume will complain. (either because in lvm batch you can't pass partition or about gpt header). The safest option is to skip the migration on the node when such a mix is detected or force all osds including those already using bluestore (option `force_filestore_to_bluestore=True` has to be passed as an extra var). If all OSDs are using filestore, then they will be migrated to bluestore. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1875777 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
changed the title
|
jenkins test centos-container-filestore_to_bluestore |
|
jenkins test centos-non_container-filestore_to_bluestore |
guits
changed the title
guits
changed the title
|
jenkins test centos-non_container-filestore_to_bluestore |
1 similar comment
|
jenkins test centos-non_container-filestore_to_bluestore |
|
jenkins test centos-non_container-filestore_to_bluestore |
1 similar comment
|
jenkins test centos-non_container-filestore_to_bluestore |
dsavineau
approved these changes
Jan 12, 2021
guits
changed the title
This was referenced Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the default of
osd_objectstorehas changed as of 3.2, somedeployments might have a mix of filestore and bluestore OSDs on a same
node. In some specific cases, there's a possibility that a filestore OSD
shares a journal/db device with a bluestore OSD. We shouldn't try to
redeploy in this context because ceph-volume will complain. (either
because in lvm batch you can't pass partition or about gpt header).
The safest option is to skip the migration on the node when such a mix
is detected or force all osds including those already using bluestore
(option
force_filestore_to_bluestore=Truehas to be passed as an extra var).If all OSDs are using filestore, then they will be migrated to
bluestore.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1875777
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com