New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ceph_key: handle error in a better way #6572

Merged

guits merged 1 commit into master from improve_info_rc

Jun 14, 2021

Collaborator

guits commented Jun 7, 2021

When calling the ceph_key module with state: info, if the ceph
command called fails, the actual error is hidden by the module which
makes it pretty difficult to troubleshoot.

The current code always states that if rc is not equal to 0 the keyring
doesn't exist.

state: info should always return the actual rc, stdout and stderr.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1964889

Signed-off-by: Guillaume Abrioux gabrioux@redhat.com

guits added backport-stable-4.0 backport-stable-5.0 backport-stable-6.0 labels

guits changed the title ~~[skip ci] ceph_key: handle error in a better way~~ ceph_key: handle error in a better way


          ceph_key: handle error in a better way

9027a7a

When calling the `ceph_key` module with `state: info`, if the ceph
command called fails, the actual error is hidden by the module which
makes it pretty difficult to troubleshoot.

The current code always states that if rc is not equal to 0 the keyring
doesn't exist.

`state: info` should always return the actual rc, stdout and stderr.

Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1964889

Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>

guits force-pushed the improve_info_rc branch from 97404e2 to 9027a7a Compare

June 7, 2021 13:35

Collaborator Author

guits commented Jun 7, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 7, 2021

jenkins test centos-non_container-all_in_one

Collaborator Author

guits commented Jun 7, 2021

jenkins test centos-non_container-collocation

Collaborator Author

guits commented Jun 7, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 7, 2021

jenkins test centos-non_container-collocation

Collaborator Author

guits commented Jun 7, 2021

jenkins test centos-non_container-switch_to_containers

Collaborator Author

guits commented Jun 8, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 8, 2021

jenkins test centos-non_container-update

Collaborator Author

guits commented Jun 8, 2021

jenkins test centos-non_container-switch_to_containers

1 similar comment

Collaborator Author

guits commented Jun 11, 2021

jenkins test centos-non_container-switch_to_containers

Collaborator Author

guits commented Jun 11, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 11, 2021

jenkins test centos-non_container-switch_to_containers

1 similar comment

Collaborator Author

guits commented Jun 11, 2021

jenkins test centos-non_container-switch_to_containers

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-non_container-switch_to_containers

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-non_container-switch_to_containers

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-container-all_in_one

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-non_container-switch_to_containers

1 similar comment

Collaborator Author

guits commented Jun 14, 2021

jenkins test centos-non_container-switch_to_containers

guits merged commit d58500a into master

guits deleted the improve_info_rc branch

June 14, 2021 21:46

This was referenced Jun 14, 2021

ceph_key: handle error in a better way (backport #6572) #6592

Merged

ceph_key: handle error in a better way (backport #6572) #6593

Merged

mergify bot mentioned this pull request

ceph_key: handle error in a better way (backport #6572) #6594

Merged

guits modified the milestone: v4.2z3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment