[skip ci] cephadm-adopt: fix rbd-mirror adoption #7350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asm0deuz
previously approved these changes
Nov 13, 2022
The recent rbdmirror refactor introduced a regression in the cephadm-adopt playbook. Given that the rbd-mirror peer addition is now done by using the monitor config-key store method during the cluster deployment, we can drop this play from the cephadm-adopt.yml playbook. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2140569 Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
guits
changed the title
|
jenkins test centos-container-cephadm_adopt |
guits
changed the title
This was referenced Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent rbdmirror refactor introduced a regression in the cephadm-adopt playbook.
Given that the rbd-mirror peer addition is now done by using the monitor config-key store method during the cluster deployment, we can drop this play from the cephadm-adopt.yml playbook.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2140569
Signed-off-by: Guillaume Abrioux gabrioux@redhat.com